Discussion:
[issue9951] introduce bytes.hex method
Arnon Yaari
2010-09-25 23:38:48 UTC
Permalink
New submission from Arnon Yaari <wiggin15 at gmail.com>:

Following up on these discussions:
http://psf.upfronthosting.co.za/roundup/tracker/issue3532
http://www.gossamer-threads.com/lists/python/dev/863892

I'm submitting a patch to add bytes.hex method in accordance to PEP 358.
The code was taken from binascii so it should be "tested".
Also added bytearray.hex and fixed the documentation and testing.

There are additional things to discuss, for example:
* multiple and different implementations of tohex\fromhex - in binascii, sha1module, bytes, bytearray...
* binascii's functions which perform the same thing, but those functions and the rest of binascii's functions receive and return wrong types. I would fix this but it breaks compatibility.

----------
components: Interpreter Core
files: bytes.hex.diff
keywords: patch
messages: 117397
nosy: wiggin15
priority: normal
severity: normal
status: open
title: introduce bytes.hex method
type: feature request
versions: Python 3.2
Added file: http://bugs.python.org/file19018/bytes.hex.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Antoine Pitrou
2010-09-26 14:49:40 UTC
Permalink
Changes by Antoine Pitrou <pitrou at free.fr>:


----------
nosy: +mark.dickinson

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Éric Araujo
2010-09-27 19:56:45 UTC
Permalink
Changes by ?ric Araujo <merwok at netwok.org>:


----------
nosy: +eric.araujo

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2010-10-02 06:14:53 UTC
Permalink
Changes by Nick Coghlan <ncoghlan at gmail.com>:


----------
nosy: +ncoghlan

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2010-10-02 06:35:10 UTC
Permalink
Nick Coghlan <ncoghlan at gmail.com> added the comment:

Patch generally looks good, but the type of retbuf is incorrect (should be Py_UNICODE* rather than wchar_t*).

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2010-10-09 11:03:33 UTC
Permalink
Changes by Arnon Yaari <wiggin15 at gmail.com>:


Added file: http://bugs.python.org/file19175/bytes.hex.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2010-10-09 11:03:41 UTC
Permalink
Changes by Arnon Yaari <wiggin15 at gmail.com>:


Removed file: http://bugs.python.org/file19018/bytes.hex.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2010-10-09 13:01:00 UTC
Permalink
Arnon Yaari <wiggin15 at gmail.com> added the comment:

fixed to Py_UNICODE

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Benjamin Peterson
2010-10-09 16:58:30 UTC
Permalink
Changes by Benjamin Peterson <benjamin at python.org>:


----------
Removed message: http://bugs.python.org/msg117862

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Raymond Hettinger
2011-04-04 00:25:37 UTC
Permalink
Raymond Hettinger <raymond.hettinger at gmail.com> added the comment:

See also: issue11756

----------
nosy: +rhettinger
versions: +Python 3.3 -Python 3.2

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Martin Panter
2013-05-20 05:40:59 UTC
Permalink
Changes by Martin Panter <vadmium+py at gmail.com>:


----------
nosy: +vadmium

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Terry J. Reedy
2013-05-26 20:39:05 UTC
Permalink
Terry J. Reedy added the comment:

Also #3532

----------
nosy: +terry.reedy
versions: +Python 3.4 -Python 3.3

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2013-07-14 07:23:45 UTC
Permalink
Arnon Yaari added the comment:

Hi, is there any chance to get this merged? This ticket has been open for almost 3 years...

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Serhiy Storchaka
2013-07-14 08:50:41 UTC
Permalink
Serhiy Storchaka added the comment:

There are several ways to do this: base64.b16encode, binascii.a2b_hex, hex(int.from_bytes(...)), etc. Why you need yet one?

----------
nosy: +serhiy.storchaka

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Serhiy Storchaka
2013-09-13 09:25:51 UTC
Permalink
Changes by Serhiy Storchaka <storchaka at gmail.com>:


----------
status: open -> pending

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2013-09-13 13:29:52 UTC
Permalink
Arnon Yaari added the comment:

You can follow the discussion I linked in the ticket description for an answer:
http://psf.upfronthosting.co.za/roundup/tracker/issue3532
Mainly the answer is: to conform to PEP 358 and to provide the opposite of bytes.fromhex.
I agree that you can use binascii, but apparently it was decided that this functionality is good to have in the builtins (what used to be encode/decode('hex') in Python 2.x, and what is now bytes.fromhex, with the missing bytes.hex). In addition, binascii works a little differently - already discussed in the given link...

----------
status: pending -> open

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Christian Heimes
2013-10-12 22:12:54 UTC
Permalink
Christian Heimes added the comment:

I like to see the feature in 3.4, too.

----------
nosy: +christian.heimes
stage: -> patch review

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Antoine Pitrou
2013-10-12 22:16:42 UTC
Permalink
Antoine Pitrou added the comment:

If it's the reverse of fromhex(), perhaps we should call it tohex()?

----------
nosy: +pitrou

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Christian Heimes
2013-10-12 22:35:06 UTC
Permalink
Christian Heimes added the comment:

Funny thing. I was searching for "tohex" when I found this ticket.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Georg Brandl
2013-10-13 07:45:40 UTC
Permalink
Georg Brandl added the comment:

Blasphemous question: why not give bytes a __hex__ method? Then you could use hex() to convert them :)

The patch is outdated; it should not use PyUnicode_AS_UNICODE, but PyUnicode_New(..., 127) and then PyUnicode_1BYTE_DATA to get the char array.

----------
nosy: +georg.brandl

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
HCT
2013-12-09 22:31:35 UTC
Permalink
HCT added the comment:

would be good if we can specify a optional flag to get all cap hex. currently, I have to do hexlify( some_bytes ).decode( 'UTF-8' ).upper(). would be good to be able to do some_bytes.hex( upper=1 )

----------
nosy: +hct

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arfrever Frehtes Taifersar Arahesis
2013-12-10 07:47:52 UTC
Permalink
Changes by Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA at GMail.Com>:


----------
nosy: +Arfrever

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Chris Lasher
2014-09-10 08:17:52 UTC
Permalink
Changes by Chris Lasher <chris.lasher at gmail.com>:


----------
nosy: +gotgenes

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
STINNER Victor
2014-09-10 12:29:40 UTC
Permalink
STINNER Victor added the comment:

New features cannot be added to Python 2 anymore, only to the current development version which is now Python 3.5.

If new methods are added to bytes, they should be added to bytearray too. Maybe we should also consider add them to memoryview? memoryview has already a .bytes() method and can be casted to type "B" (array of integers in range 0..255).

The float type has .hex() and .fromhex() methods. We should kepe these names to stay consistent. Which kind of output do you prefer? "0xHH 0xHH ...", "HH HH HH ..." or "HHHHHH..."? Do you want to add parameters to choose the format?
binascii.hexlify('abc')
'616263'

----------
nosy: +haypo

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Terry J. Reedy
2014-09-10 17:58:54 UTC
Permalink
Terry J. Reedy added the comment:

To answer Serhiy, the goal is to have a bytes method that represents bytes as bytes rather than as a mixture of bytes and encoded ascii characters. This would aid people who work with bytes that are not encoded ascii and that do not embed encoded ascii. It should not be necessary to import anything.
hex(int.from_bytes(b'abc', 'big'))
'0x616263'
is a bit baroque and produces a hex representation of an int, not of multiple bytes.

I think following the float precedent is a good idea.
float.fromhex(1.5.hex())
1.5
float.fromhex('0x1.8000000000000p+0').hex()
'0x1.8000000000000p+0'

The output of bytes.hex should be one that is accepted by bytes.fromhex, which is to say, hex 'digit' pairs. Spaces are optionally allowed between pairs. I would add a 'spaces' parameter, defaulting to False. to output spaces when set to true. (Or possible reverse the default -- what do potential users think?)

A possible altermative for the parameter could be form='' (default), form=' ' (add spaces), and form='x' to add '\x' prefixes. I don't know that adding '\x' would be useful. The prefixes are not accepted by .fromhex.

----------
versions: +Python 3.5 -Python 3.4

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
HCT
2014-09-10 22:30:31 UTC
Permalink
HCT added the comment:

@Victor

binascii.hexlify('abc') doesn't work in 3.4. I assume this is a new thing for 3.5
import binascii
binascii.hexlify('abc')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'str' does not support the buffer interface
binascii.hexlify(b'abc')
b'616263'


@Terry
I think that space shouldn't be done by the hex function. if you allow space between each hex, then what do you do if the bytes are actually from array of 64-bit ints? getting into support separating space for every X bytes is probably not the scope of this.


I propose the hex functions for bytes/memoryview/bytearray should be as follow. I prefer to not have the '0x' prefix at all, but I understand all other hex functions adds it. would be good to have the option to not have the prefix.

bytes.hex( byte_order = sys.byteorder ) returns a hex string in small letter. ex. c0ffee

bytes.HEX( byte_order = sys.byteorder ) returns a hex string in capital letters. ex. DEADBEEF

bytes.from_hex( hex_str, byte_order = sys.byteorder ) returns a bytes object. ex. b'\xFE\xFF'


another more flexible way is to have hex function accept a format similar to how sscanf works, but this will probably bring lots of trouble for all kinds of variants to support and the required error checks.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2014-09-10 23:04:07 UTC
Permalink
import codecs
codecs.encode(b"abc", "hex")
b'616263'
import binascii
binascii.hexlify(b"abc")
b'616263'
import base64
base64.b16encode(b"abc")
b'616263'
hex(int.from_bytes(b"abc", "big"))
'0x616263'
hex(int.from_bytes(b"abc", "little"))
'0x636261'

Thus, the underlying purpose of this proposal is to provide a single "more obvious way to do it". As per the recent discussion on python-ideas, the point where that is most useful is in debugging output.

However, rather than a new method on bytes/bytearray/memoryview for this, I instead suggest it would be appropriate to extend the default handling of the "x" and "X" format characters to accept arbitrary bytes-like objects. The processing of these characters would be as follows:

"x": display a-f as lowercase digits
"X": display A-F as uppercase digits
"#": includes 0x prefix
".precision": chunks output, placing a space after every <precision> bytes
",": uses a comma as the separator, rather than a space

Output order would match binascii.hexlify()

Examples:

format(b"xyz", "x") -> '78797a'
format(b"xyz", "X") -> '78797A'
format(b"xyz", "#x") -> '0x78797a'

format(b"xyz", ".1x") -> '78 79 7a'
format(b"abcdwxyz", ".4x") -> '61626364 7778797a'
format(b"abcdwxyz", "#.4x") -> '0x61626364 0x7778797a'

format(b"xyz", ",.1x") -> '78,79,7a'
format(b"abcdwxyz", ",.4x") -> '61626364,7778797a'
format(b"abcdwxyz", "#,.4x") -> '0x61626364,0x7778797a'

This approach makes it easy to inspect binary data, with the ability to inject regular spaces or commas to improved readability. Those are the basic features needed to support debugging.

Anything more complicated than that, and we're starting to want something more like the struct module.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Terry J. Reedy
2014-09-10 23:29:34 UTC
Permalink
Terry J. Reedy added the comment:

The proposal is to add a .hex method (similar to binascii.hexlify) that is the inverse of .fromhex (similar to binascii.unhexlify), as originally specified in PEP 358.
http://legacy.python.org/dev/peps/pep-0358/
"The object has a .hex() method that does the reverse [of .frombytes]
bytes([92, 83, 80, 255]).hex()
'5c5350ff'
"
If we add .hex, I think we should stick with this: no 0x or \x prefix.

To aid debugging, I would change spaces to be None or a positive int n to insert a space every n bytes. So .hex(8) for an array of 64 bit ints.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
HCT
2014-09-10 23:55:33 UTC
Permalink
HCT added the comment:

@Terry

natural bytes do not have space between them. I would think adding space is for typesetting situation which should be done by user's post-processing.

I agree to not have any prefix to make .hex and from_hex uniform. the \x is the str representation of bytes when you print a bytes object directly in Python. the actual bytes object doesn't have that \x prefix.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2014-09-10 23:57:04 UTC
Permalink
Nick Coghlan added the comment:

Good point Terry - I split the proposal to support bytes-like objects for 'x' and 'X' in string formatting out to issue 22385.

For bytes.hex, I'm inclined to stick with the dirt simple option described in PEP 358: the exact behaviour of the current binascii.hexlify().

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2014-09-11 00:06:21 UTC
Permalink
Nick Coghlan added the comment:

Open question: the current patch adds bytes.hex() and bytearray.hex(). Should we also add memoryview.hex(), or split that suggestion out to a separate proposal?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Mark Lawrence
2014-09-11 00:20:55 UTC
Permalink
Mark Lawrence added the comment:

I'd say add memoryview.hex() here as everything seems related. Victor has also mentioned memoryview in msg226692.

----------
nosy: +BreamoreBoy

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Chris Lasher
2014-09-11 07:09:25 UTC
Permalink
Chris Lasher added the comment:

int has int.from_bytes and int.to_bytes.

Currently, bytes has bytes.fromhex. Would the core developers please consider naming the method "bytes.tohex" instead of "bytes.hex", so there's at least a modicum of consistency in the method names of Python's builtin types?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Marc-Andre Lemburg
2014-09-11 07:42:36 UTC
Permalink
Post by HCT
import codecs
codecs.encode(b"abc", "hex")
b'616263'
import binascii
binascii.hexlify(b"abc")
b'616263'
import base64
base64.b16encode(b"abc")
b'616263'
hex(int.from_bytes(b"abc", "big"))
'0x616263'
hex(int.from_bytes(b"abc", "little"))
'0x636261'
Thus, the underlying purpose of this proposal is to provide a single "more obvious way to do it". As per the recent discussion on python-ideas, the point where that is most useful is in debugging output.
"x": display a-f as lowercase digits
"X": display A-F as uppercase digits
"#": includes 0x prefix
".precision": chunks output, placing a space after every <precision> bytes
",": uses a comma as the separator, rather than a space
Hmm, but those would then work for str.format() as well, right ?

Since "x" and "X" are already used to convert numbers to hex
representation, opening these up for bytes sounds like it could
easily mask TypeErrors for cases where you really want an integer
to be formatted as hex and not bytes.

----------
nosy: +lemburg

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2014-09-23 10:00:24 UTC
Permalink
Nick Coghlan added the comment:

Updated issue title to indicate proposal also covers bytearray and memoryview.

----------
title: introduce bytes.hex method -> introduce bytes.hex method (also for bytearray and memoryview)

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Barry A. Warsaw
2014-09-23 11:44:44 UTC
Permalink
Changes by Barry A. Warsaw <barry at python.org>:


----------
nosy: +barry

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Ethan Furman
2014-11-07 15:37:18 UTC
Permalink
Changes by Ethan Furman <***@stoneleaf.us>:


----------
nosy: +ethan.furman

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2015-04-13 14:03:47 UTC
Permalink
Nick Coghlan added the comment:

Arnon is here at the PyCon 2015 sprints, so bringing the current status up to date:

= Why *.hex()? =

* That's the name in PEP 358
* That's the name of the comparable float method

= Why add it to the builtin types? =

* To provide One Obvious Way To Do It, rather than the current 5 (or so) non-obvious ways listed above
* That's what PEP 358 proposed

= Why postpone configurability and str.format() integration? =

* Because these are more complex questions that can be left out of the "minimum useful feature" of new methods on the builtins and hence have been moved out to issue 22385 (which depends on this issue, and would likely require a PEP to resolve all the technical details)

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-13 16:52:56 UTC
Permalink
Changes by Arnon Yaari <***@gmail.com>:


----------
nosy: +eric.smith

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-13 19:43:01 UTC
Permalink
Changes by Arnon Yaari <***@gmail.com>:


Removed file: http://bugs.python.org/file19175/bytes.hex.diff

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-13 19:55:06 UTC
Permalink
Arnon Yaari added the comment:

I added the implementation for memoryview, updated to use PyUnicode_New etc., and moved the common implementation to its own file for code reuse.

----------
Added file: http://bugs.python.org/file38947/bytes.hex.diff

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-13 20:30:57 UTC
Permalink
Changes by Arnon Yaari <***@gmail.com>:


Removed file: http://bugs.python.org/file38947/bytes.hex.diff

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-13 20:31:56 UTC
Permalink
Changes by Arnon Yaari <***@gmail.com>:


Added file: http://bugs.python.org/file38961/bytes.hex.diff

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
STINNER Victor
2015-04-14 08:15:41 UTC
Permalink
Changes by STINNER Victor <***@gmail.com>:


----------
nosy: -haypo

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2015-04-25 06:36:58 UTC
Permalink
Changes by Nick Coghlan <***@gmail.com>:


----------
assignee: -> ncoghlan

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Arnon Yaari
2015-04-25 10:54:48 UTC
Permalink
Arnon Yaari added the comment:

minor updates to stdtypes.rst. I also want to add a line to whatsnew/3.5 but don't know how to put it in words - maybe it's better if someone with better english will add it.

----------
Added file: http://bugs.python.org/file39204/bytes.hex-1.diff

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-25 22:39:03 UTC
Permalink
Gregory P. Smith added the comment:

bytes.hex-1.diff looks good, i'll take care of committing this and adding a what's new entry. thanks!

----------
assignee: ncoghlan -> gregory.p.smith
nosy: +gregory.p.smith

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-04-25 23:22:38 UTC
Permalink
Roundup Robot added the comment:

New changeset c9f1630cf2b1 by Gregory P. Smith in branch 'default':
Implements issue #9951: Adds a hex() method to bytes, bytearray, & memoryview.
https://hg.python.org/cpython/rev/c9f1630cf2b1

----------
nosy: +python-dev

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-04-25 23:42:53 UTC
Permalink
Roundup Robot added the comment:

New changeset 955a479b31a8 by Gregory P. Smith in branch 'default':
Issue9951: update _hashopenssl and md5module to use _Py_strhex().
https://hg.python.org/cpython/rev/955a479b31a8

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-25 23:51:28 UTC
Permalink
Changes by Gregory P. Smith <***@krypto.org>:


----------
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-26 00:36:37 UTC
Permalink
Gregory P. Smith added the comment:

note quite fixed, looks like some of the buildbots are having fun not compiling with this change:

http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/9569/steps/compile/logs/stdio

investigating...

----------
resolution: fixed ->
status: closed -> open

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-26 00:39:22 UTC
Permalink
Gregory P. Smith added the comment:

i missed the hg adds :)

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-04-26 00:41:13 UTC
Permalink
Roundup Robot added the comment:

New changeset a7737204c221 by Gregory P. Smith in branch 'default':
Add the files missing from c9f1630cf2b1 for issue9951.
https://hg.python.org/cpython/rev/a7737204c221

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-04-26 00:42:25 UTC
Permalink
Roundup Robot added the comment:

New changeset 7f0811452d0f by Gregory P. Smith in branch 'default':
Switch binascii over to using the common _Py_strhex implementation for its hex
https://hg.python.org/cpython/rev/7f0811452d0f

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Nick Coghlan
2015-04-26 02:36:38 UTC
Permalink
Nick Coghlan added the comment:

Thank you Arnon, and thank you Greg!

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-26 04:28:33 UTC
Permalink
Gregory P. Smith added the comment:

I see some _Py_strhex related link errors on the Windows buildbots:

http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/9642/steps/compile/logs/stdio

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-04-26 05:00:10 UTC
Permalink
Roundup Robot added the comment:

New changeset b46308353ed9 by Gregory P. Smith in branch 'default':
Add missing PyAPI_FUNC macro's to the public functions as other .c files do
https://hg.python.org/cpython/rev/b46308353ed9

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Gregory P. Smith
2015-04-26 05:07:16 UTC
Permalink
Changes by Gregory P. Smith <***@krypto.org>:


----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Berker Peksag
2015-04-26 07:49:42 UTC
Permalink
Changes by Berker Peksag <***@gmail.com>:


----------
stage: commit review -> resolved

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________
Roundup Robot
2015-11-10 17:19:10 UTC
Permalink
Roundup Robot added the comment:

New changeset f3d8bb3ffa98 by Stefan Krah in branch '3.5':
Iaaue #25598: Fix memory_hex from #9951 for non-contiguous buffers.
https://hg.python.org/cpython/rev/f3d8bb3ffa98

----------

_______________________________________
Python tracker <***@bugs.python.org>
<http://bugs.python.org/issue9951>
_______________________________________

Loading...